Errors running `make` on linux

eldun commented 1 year ago

Hi,

I'm trying to build Milky from source following the very simple instructions in INSTALL.md, but I'm encountering failures when running make:

[  1%] Building CXX object src/midi/CMakeFiles/midi.dir/posix/MidiReceiver_pthread.cpp.o
In file included from /home/evan/Projects/third-party/MilkyTracker/src/midi/posix/MidiReceiver_pthread.cpp:34:
/usr/include/rtmidi/RtMidi.h:137:19: error: expected ‘,’ or ‘...’ before ‘&&’ token
  137 |      RtMidi(RtMidi&& other) noexcept;
      |                   ^~
/usr/include/rtmidi/RtMidi.h:137:6: error: invalid constructor; you probably meant ‘RtMidi (const RtMidi&)’
  137 |      RtMidi(RtMidi&& other) noexcept;
      |      ^~~~~~

...

I looked for similar issues, but couldn't find a solution. I have a feeling this is a simple fix... can anyone offer up some assistance?

Thanks.

bratpeki commented 1 year ago

I recently addressed this issue here. noexcept is a feature available in C++11.

While we're waiting for the devs to look into the pull request, change the 26th line of the CMakeLists.txt file to this: set(CMAKE_CXX_STANDARD 11).

coderofsalvation commented 1 year ago

thank you very much for adressing this, it has been fixed in v1.04 🎉

milkytracker / MilkyTracker

Errors running `make` on linux #309