It resulted in a bug which retriggered a sample (which has a pingpong/forward loop set) rapidly (as soon as the end of the sample was reached).
If you test this with a looped pad-sample (and holding key 'q'), you'll notice that with this 'fix' the note now sustains properly (including looping).
I've tested the note-offs and they worked well too (so no regression), it's quite comfortable to play/records notes now.
This fixes a regression bug which was introduced after keyjazz got implemented https://github.com/milkytracker/MilkyTracker/commit/477e611b27c425857e636a7c1e0d89e8bb8b2817.
It resulted in a bug which retriggered a sample (which has a pingpong/forward loop set) rapidly (as soon as the end of the sample was reached). If you test this with a looped pad-sample (and holding key 'q'), you'll notice that with this 'fix' the note now sustains properly (including looping). I've tested the note-offs and they worked well too (so no regression), it's quite comfortable to play/records notes now.
Big thanks to moewgli https://github.com/milkytracker/MilkyTracker/issues/304