Open malespiaut opened 1 year ago
Hi malespiaut, so far I guess warnings ares a bit of an 'it aint hurt until it hurts' kind of thing. My thoughts are:
src/tracker
and src/ppui
, perhaps the other foldersbtw forgot to mention: thank you very much for the heads up. Perhaps there's a bunch of warnings which don't require crossplatform testing (the current CI builds windows & linux) but I don't know much about mac.
btw2. which category warnings are about functions not returning a value? We got bitten by that in the past :)
Thank you for your answer @coderofsalvation
I, for one, wouldn't go down the path of refactoring the code to fix warnings. I was thinking about “easy” warnings frist (-Wunused-parameter
can be fixed with a simple (void)
). I'm too foreign to this codebase to engage on more complex fixes.
I'm not able to test on anything else than Linux for now. But I have an old late-2009 MacBook sleeping around. I think that it can be upgraded from macOS 10.5 to 10.11. One of my friends can help me up with anything macOS-related. But don't hold your breath as I'm, as everyone else here, very busy already. :P
Hello,
I usually compile my projects with the list of warnings:
and I've complied the latest revision of MilkyTracker using these.
As a result, when sorting and cleaning compiler output, it turns out that there are 1481 unique warnings for MilkTracker.
Here's a list of the number of occurence:
There's also an extra
PPSystem_POSIX.cpp:(.text+0x13): warning: the use of
tmpnam' is dangerous, better usemkstemp'
.Luckily, a lot of them are easily fixable.
-Wunused-parameters
are only a matter of adding(void)name_of_unused_parameter
in the function, and-Wshadow
is “only” about renaming variables.While I wanted to commit to your project hoping to increase code quality, I don't know if you are looking forward to review, test, and merge such commits. Hence this message.
Best regards