milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.7k stars 162 forks source link

SDL: Crash when inserting the number 2 on AZERTY #33

Closed Deltafire closed 9 years ago

Deltafire commented 9 years ago

From #milkytracker:

--> LazyBeard (~vanguarti@AStDenis-651-1-297-225.w81-248.abo.wanadoo.fr) has joined #milkytracker
<LazyBeard> Hi. I'm too lazy to create an account on Github or on Milkytracker forum, so I'll just do a bug report here.
<@pailes> LazyBeard, no problem, go on
<LazyBeard> I managed to compile the latest version of Milkytracker 0.90.87 on Lubuntu 14.10 x86_64, and when I use it, no matter what I do, where I am in the app, or whatever, I can instantly crash it just by pushing MAJ + 2 (the key above the letters where there is the number 2)
<LazyBeard> I then get in the console : Crashed with signal 11 [...]  A backup has been saved to ~/BACKUPnn.XM \n  Segmentation fault (core dumped)
<@Deltafire> MAJ+2?
<@Deltafire> the " symbol is above the 2 for me
<LazyBeard> I must precise that I am using an AZERTY keyboard layout.
<@Deltafire> what is MAJ?
<LazyBeard> MAJ is the way french called the SHIFT key.
<LazyBeard> call* sorry
<@Deltafire> ok, so you're trying to insert the number 2?
<LazyBeard> Not necessarily. I discovered that bug by trying to enter a 2 when giving a sample size, but it turns out that I can crash the program when I push 2 at any moment
Deltafire commented 9 years ago

LazyBeard reports that the bug doesn't affect 0.90.86.

dwhinham commented 9 years ago

I've encountered this before, but not got around to investigating it properly. I was able to trigger what's presumably the same crash by using LGUI+2 under Ubuntu.

This should fix it hopefully.

Sorry about the spam above!