search

milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.67k stars 160 forks source link

xm-form typo fixes #330

Closed quasilyte closed 3 months ago

quasilyte commented 8 months ago

The length of a word-typed field is usually written as 2. It's confusing to see it being described as a field of length=1.

coderofsalvation commented 3 months ago

thanks for reporting. But how were you sure the word is a word then?

quasilyte commented 3 months ago

Nope, I'm not sure it's a "word" anymore. Should it be changed to "byte" instead?

coderofsalvation commented 3 months ago

I think @sagamusix is one of those people who might know.

However, just by the looks of it (Since one envelope point takes 2 words (2*2 bytes)) it does not seem to be a typo. Perhaps you are confusing Length with bytesize ? I agree Length is somewhat ambigious but it is used in the same way elsewhere in the spec.

quasilyte commented 3 months ago

Perhaps you are confusing Length with bytesize?

Yes, I might be.

coderofsalvation commented 3 months ago

OK then I will leave this as is for now (as it is somewhat of an ancient historial document to some folks). But thanks for the heads up. Feel free to re-open the issue at any point.