search

milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.67k stars 160 forks source link

MIDI support no longer optional #332

Closed Deltafire closed 7 months ago

Deltafire commented 8 months ago

Logged via IRC:

<plasma41> MIDI support in milkytracker was mistakenly made non-optional by commit f578adfa333ea52c84654acf08d6024ae76c10fd. The addition of the REQUIRED keyword of the find_package() command results in the 'else' codepath in the following 'if' conditional never being reached.

coderofsalvation commented 8 months ago

Thank you very much for logging this.

find_package(RTMIDI "2.1.0" REQUIRED) # 2.1.0 and above

OK I guess REQUIRED does not mean '2.1.0' and above. Should look up the CMAKE docs to do this properly.

Deltafire commented 7 months ago

Fixed in https://github.com/milkytracker/MilkyTracker/commit/50273e401024a9ece4bcb095f650d1efaa628bf4