milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.67k stars 160 forks source link

Can we have an option for odd channel numbers at least? #343

Closed Hundredlegger closed 2 months ago

Hundredlegger commented 3 months ago

I still believe that someday, true IT compatibility will come, but in the meantime, is there a way to select whenever "add" or "sub" will add or sub a different number of channels?

Like, make it in the settings so that you can change if it will add or sub "1", "2" or "4" channels at a time.

I mean, we kinda already did this with how many XM channels are allowed, like "32", "64" or "128", so why not with the number of channels you can add or sub?

(Also, is there a setting somewhere that allows you to switch between fine volume control like "h100/256 to 0" to hard volume control like the original Fasstracker II does "h40/64 to 0"?)

coderofsalvation commented 2 months ago

Hi @Hundredlegger, thanks for submitting to this issuetracker.

Just curious, did you find other people who want this, and what is the problem it solved exactly? Otherwise it's just a matter of clicking twice or more on the 'add' button no?

About the "h100/256 to 0" vs "h40/64 to 0", can you elaborate that? I don't remember ever having stumbled upon that in FT2. What was the purpose of it and where is the setting?

Hundredlegger commented 2 months ago

@coderofsalvation I'm referring to how Fasttracker 2's envelope can only be in y0 to y64, as in, there are only 64 steps in the y direction. In Milkytracker, I noticed that it is y0 to y256, meaning that there are 256 steps in the vertical direction.

As for the channel thing, I just think it would be the least controversial change, since it doesn't tamper with anything that could potentially introduce new bugs to the player.

coderofsalvation commented 2 months ago

In Milkytracker, I noticed that it is y0 to y256, meaning that there are 256 steps in the vertical direction.

Ah OK got it. Yes I guess there's 256 possible vertical values, and in the FT2 days the screen-resolutions did not allow for that kind of control. We're living in good times these days.

I mean, we kinda already did this with how many XM channels are allowed, like "32", "64" or "128", so why not with the number of channels you can add or sub?

I think the max-channels were bumped up over time (as hardware became better). A reason for adding/substracting channels by KiSS one-time increments could be: because it's a destructive action. Imagine having channel add/sub configured to 4, and then pressing sub on an 4-channel pattern after working on it..*poof*.

As for the channel thing, I just think it would be the least controversial change, since it doesn't tamper with anything that could potentially introduce new bugs to the player.

Perhaps not the player yes. From a UX point of view: which problem does it solve exactly compared to clicking add/sub multiple times? Perhaps I'm not understanding your usecase correctly? (please elaborate if so. Are there trackers which demonstrate your usecase?) Anyways thanks for the heads up.

Hundredlegger commented 2 months ago

@coderofsalvation Is there an option to turn it off? Having 256 steps is nice, but it is not nice when I have to be forced to use it.

Also, the KiSS principle is pretty stupid. Impulse Tracker has the simplest mechanic, since it has all channels available and whichever one you didn't use is trimmed from the file you saved. If you still want the ability to manually choose how many channels you have, the simplest implementation is to have a button where you can input a number to choose how many channels you want.

coderofsalvation commented 2 months ago

Ah ok, so you mean a textfield input (sorry I did not get it before). To be frank: I (as a volunteer donating my freetime) don't have the bandwidth to experiment with it right now. Maybe you can create a more detailed userstory, and find another maintainer/dev to hash out an PR. As it's not a bug, for now I'm closing this issue (feel free to append more thoughts though)