search

milkytracker / MilkyTracker

An FT2 compatible music tracker
http://milkytracker.github.io/
Other
1.72k stars 162 forks source link

Windows: Drag & Drop only works with recognised file extensions #38

Closed Deltafire closed 9 years ago

Deltafire commented 9 years ago

Subbi mentioned this at Sundown.

dwhinham commented 9 years ago

In Cocoa I didn't intend to allow dragging unrecognised file formats, but are we saying it's a pretty useful feature for loading arbitrary data as samples, etc?

If so, I agree - let's give this to Windows users too.

Deltafire commented 9 years ago

I think the main problem is Amiga modules have traditionally been named “mod.filename” instead of “filename.mod” - and they still are named this way. At the moment they have to be drag-dropped in Cocoa, and loaded using the file dialog only on Windows.

On 20 Aug 2015, at 18:25, Dale Whinham notifications@github.com wrote:

In Cocoa I didn't intend to allow dragging unrecognised file formats, but are we saying it's a pretty useful feature for loading arbitrary data as samples, etc?

If so, I agree - let's give this to Windows users too.

— Reply to this email directly or view it on GitHub https://github.com/Deltafire/MilkyTracker/issues/38#issuecomment-133082771.

sagamusix commented 9 years ago

Can't reproduce this on Windows, would be weird anyway because that's not how a simple Drag&Drop handler should work (and in fact it doesn't in the win32 code, just checked). Here I can just throw any renamed mod file at Milky and it loads it - which is sensible for the reason Deltafire mentioned (also because there are many different extensions for the same old formats, e.g. M15/NST/etc. for old 15-sample MODs.

dwhinham commented 9 years ago

Can we clarify what needs to be done, then (if anything)? :smiley:

sagamusix commented 9 years ago

Asking Subi for steps to reproduce, because from what I can tell Milky's Drag&Drop integration works as intended on Windows.

subi211 commented 9 years ago

Okay, this is quite embarrassing, but I can't actually repro the problem now. :( I'd only noticed it recently, so I must've just been clumsy and dragged the file over the wrong part of the screen, because you're right, it'll accept any file. Sorry for that. O__o

Deltafire commented 9 years ago

No worries! This makes it an easy fix :)