Closed xracecar closed 7 years ago
Thanks for reporting, could you provide any error messages written on command line and/or a core dump?
To get those do the following:
ulimit -c unlimited
Okay, well the ulimit -c unlimited
didn't do its thing, as there was nothing when MilkyTracker crashed. I did open -a MilkyTracker
in the Terminal after I typed in the code above, and so, nothing popped up.
Thanks for the screenshot. Someone with more experience with OSX will have to look into that.
Clicking the Report... button and pasting as much as possible here would be a good start, I think it is supposed to show a stack trace in some cases.
There is very little information to go on in this bug report, we will need more to be of any help. Have you got a faulty .wav file you can attach, or does it happen for all .wav files? You didn't specify.
I can load .wav samples via drag and drop or by the 'Load' button no problem over here.
Alright, here's the load of code that should be viable to sift out the error. It happens with all .wav files, and I'm running on the 1.00.00 version that allows the custom resolution.
Crashed Thread: 0 Dispatch queue: com.apple.main-thread
Exception Type: EXC_BAD_INSTRUCTION (SIGILL) Exception Codes: 0x0000000000000001, 0x0000000000000000 Exception Note: EXC_CORPSE_NOTIFY
Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.Titan.MilkyTracker 0x0000000101b8cf93 lha_basic_reader_new + 32 1 com.Titan.MilkyTracker 0x0000000101b8d11e lha_reader_new + 41 2 com.Titan.MilkyTracker 0x0000000101b87277 (anonymous namespace)::LHAReaderWrapper::LHAReaderWrapper(XMFile&) + 103 3 com.Titan.MilkyTracker 0x0000000101b86abd (anonymous namespace)::LHAReaderWrapper::LHAReaderWrapper(XMFile&) + 29 4 com.Titan.MilkyTracker 0x0000000101b869ee DecompressorLHA::identify(XMFile&) + 62 5 com.Titan.MilkyTracker 0x0000000101b7f41b Decompressor::identify(XMFile&) + 107 6 com.Titan.MilkyTracker 0x0000000101a9a970 FileIdentificator::isCompressed() + 96 7 com.Titan.MilkyTracker 0x0000000101a9a35e FileIdentificator::getFileType() + 190 8 com.Titan.MilkyTracker 0x0000000101b4cb29 Tracker::prepareLoading(FileTypes, PPString const&, bool, bool, bool) + 1065 9 com.Titan.MilkyTracker 0x0000000101b4bcc6 Tracker::loadTypeFromFile(FileTypes, PPString const&, bool, bool, bool) + 134 10 com.Titan.MilkyTracker 0x0000000101b4d56d Tracker::loadTypeWithDialog(FileTypes, bool, bool) + 1421 11 com.Titan.MilkyTracker 0x0000000101b4d722 Tracker::loadType(FileTypes) + 130 12 com.Titan.MilkyTracker 0x0000000101b16584 SectionSamples::handleEvent(PPObject, PPEvent) + 1188 13 com.Titan.MilkyTracker 0x0000000101c2983a PPButton::handleButtonRelease(bool&, bool&, PPEvent, EEventDescriptor) + 314 14 com.Titan.MilkyTracker 0x0000000101c294c0 PPButton::dispatchEvent(PPEvent) + 528 15 com.Titan.MilkyTracker 0x0000000101c2aa8e PPContainer::dispatchEvent(PPEvent) + 638 16 com.Titan.MilkyTracker 0x0000000101c2aa8e PPContainer::dispatchEvent(PPEvent) + 638 17 com.Titan.MilkyTracker 0x0000000101c43882 PPScreen::raiseEvent(PPEvent) + 1986 18 com.Titan.MilkyTracker 0x0000000101b79a33 RaiseEventSynchronized(PPEvent) + 67 19 com.Titan.MilkyTracker 0x0000000101b7ce20 -[MTTrackerView mouseUp:] + 368 20 com.apple.AppKit 0x00007fff9515c713 -[NSWindow _handleMouseUpEvent:isDelayedEvent:] + 119 21 com.apple.AppKit 0x00007fff9515d3ad -[NSWindow _reallySendEvent:isDelayedEvent:] + 212 22 com.apple.AppKit 0x00007fff94b9c539 -[NSWindow sendEvent:] + 517 23 com.apple.AppKit 0x00007fff94b1ca38 -[NSApplication sendEvent:] + 2540 24 com.apple.AppKit 0x00007fff94983df2 -[NSApplication run] + 796 25 com.apple.AppKit 0x00007fff9494d368 NSApplicationMain + 1176 26 com.Titan.MilkyTracker 0x0000000101b7ee42 main + 34 27 com.Titan.MilkyTracker 0x0000000101a80cd4 start + 52
Thread 1: 0 libsystem_kernel.dylib 0x00007fff964b55e2 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff91004578 _pthread_wqthread + 1283 2 libsystem_pthread.dylib 0x00007fff91002341 start_wqthread + 13
Thread 2:: Dispatch queue: com.apple.libdispatch-manager 0 libsystem_kernel.dylib 0x00007fff964b5efa kevent_qos + 10 1 libdispatch.dylib 0x00007fff92761165 _dispatch_mgr_invoke + 216 2 libdispatch.dylib 0x00007fff92760dcd _dispatch_mgr_thread + 52
Thread 3: 0 libsystem_kernel.dylib 0x00007fff964b55e2 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff91004578 _pthread_wqthread + 1283 2 libsystem_pthread.dylib 0x00007fff91002341 start_wqthread + 13
Thread 4: 0 libsystem_kernel.dylib 0x00007fff964b55e2 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff91004578 _pthread_wqthread + 1283 2 libsystem_pthread.dylib 0x00007fff91002341 start_wqthread + 13
Thread 5:: Dispatch queue: TBrowserViewDataSource 0 libsystem_kernel.dylib 0x00007fff964b4db6 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff91005728 _pthread_cond_wait + 767 2 com.apple.FinderKit 0x00007fff8d1db575 ModifyDataSourceOnMainThreadSync(FI_TBrowserViewDataSource, FI_TBVDSChangedNotificationData, std::1::function<void ()> const&) + 442 3 com.apple.FinderKit 0x00007fff8d1de4e6 49-[FI_TBrowserViewDataSource closeContainerNodes:]_block_invoke + 355 4 libdispatch.dylib 0x00007fff9276693d _dispatch_call_block_and_release + 12 5 libdispatch.dylib 0x00007fff9275b40b _dispatch_client_callout + 8 6 libdispatch.dylib 0x00007fff9276003b _dispatch_queue_drain + 754 7 libdispatch.dylib 0x00007fff92766707 _dispatch_queue_invoke + 549 8 libdispatch.dylib 0x00007fff9275b40b _dispatch_client_callout + 8 9 libdispatch.dylib 0x00007fff9275f29b _dispatch_root_queue_drain + 1890 10 libdispatch.dylib 0x00007fff9275eb00 _dispatch_worker_thread3 + 91 11 libsystem_pthread.dylib 0x00007fff910044de _pthread_wqthread + 1129 12 libsystem_pthread.dylib 0x00007fff91002341 start_wqthread + 13
Thread 6: 0 libsystem_kernel.dylib 0x00007fff964b55e2 __workq_kernreturn + 10 1 libsystem_pthread.dylib 0x00007fff91004578 _pthread_wqthread + 1283 2 libsystem_pthread.dylib 0x00007fff91002341 start_wqthread + 13
Thread 7: 0 libsystem_kernel.dylib 0x00007fff964aef72 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff964ae3b3 mach_msg + 55 2 com.apple.audio.midi.CoreMIDI 0x0000000101e7dbb7 XServerMachPort::ReceiveMessage(int&, void, int&) + 125 3 com.apple.audio.midi.CoreMIDI 0x0000000101e99095 MIDIProcess::RunMIDIInThread() + 135 4 com.apple.audio.midi.CoreMIDI 0x0000000101e7ed02 XThread::RunHelper(void) + 10 5 com.apple.audio.midi.CoreMIDI 0x0000000101e7e92e CAPThread::Entry(CAPThread*) + 80 6 libsystem_pthread.dylib 0x00007fff9100499d _pthread_body + 131 7 libsystem_pthread.dylib 0x00007fff9100491a _pthread_start + 168 8 libsystem_pthread.dylib 0x00007fff91002351 thread_start + 13
Thread 8:: com.apple.audio.IOThread.client 0 libsystem_kernel.dylib 0x00007fff964aef72 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff964ae3b3 mach_msg + 55 2 com.apple.audio.CoreAudio 0x00007fff9559b35e HALB_MachPort::SendMessageWithReply(unsigned int, unsigned int, unsigned int, unsigned int, mach_msg_header_t, bool, unsigned int) + 98 3 com.apple.audio.CoreAudio 0x00007fff9559b2ec HALB_MachPort::SendSimpleMessageWithSimpleReply(unsigned int, unsigned int, int, int&, bool, unsigned int) + 42 4 com.apple.audio.CoreAudio 0x00007fff955996a9 HALC_ProxyIOContext::IOWorkLoop() + 1149 5 com.apple.audio.CoreAudio 0x00007fff9559915e HALC_ProxyIOContext::IOThreadEntry(void) + 88 6 com.apple.audio.CoreAudio 0x00007fff95599033 HALB_IOThread::Entry(void*) + 75 7 libsystem_pthread.dylib 0x00007fff9100499d _pthread_body + 131 8 libsystem_pthread.dylib 0x00007fff9100491a _pthread_start + 168 9 libsystem_pthread.dylib 0x00007fff91002351 thread_start + 13
Thread 9:: CVDisplayLink 0 libsystem_kernel.dylib 0x00007fff964b4db6 __psynch_cvwait + 10 1 libsystem_pthread.dylib 0x00007fff9100575e _pthread_cond_wait + 821 2 com.apple.CoreVideo 0x00007fff8e9cf0d8 CVDisplayLink::waitUntil(unsigned long long) + 232 3 com.apple.CoreVideo 0x00007fff8e9ceed1 CVDisplayLink::runIOThread() + 511 4 com.apple.CoreVideo 0x00007fff8e9ce9a9 startIOThread(void*) + 147 5 libsystem_pthread.dylib 0x00007fff9100499d _pthread_body + 131 6 libsystem_pthread.dylib 0x00007fff9100491a _pthread_start + 168 7 libsystem_pthread.dylib 0x00007fff91002351 thread_start + 13
Thread 10:: com.apple.NSEventThread 0 libsystem_kernel.dylib 0x00007fff964aef72 mach_msg_trap + 10 1 libsystem_kernel.dylib 0x00007fff964ae3b3 mach_msg + 55 2 com.apple.CoreFoundation 0x00007fff934b61c4 CFRunLoopServiceMachPort + 212 3 com.apple.CoreFoundation 0x00007fff934b568c CFRunLoopRun + 1356 4 com.apple.CoreFoundation 0x00007fff934b4ed8 CFRunLoopRunSpecific + 296 5 com.apple.AppKit 0x00007fff94ae5d95 _NSEventThread + 149 6 libsystem_pthread.dylib 0x00007fff9100499d _pthread_body + 131 7 libsystem_pthread.dylib 0x00007fff9100491a _pthread_start + 168 8 libsystem_pthread.dylib 0x00007fff91002351 thread_start + 13
Thread 11:: com.apple.appkit-heartbeat 0 libsystem_kernel.dylib 0x00007fff964b510a semwait_signal + 10 1 libsystem_c.dylib 0x00007fff90b03d0f nanosleep + 199 2 libsystem_c.dylib 0x00007fff90b03c02 usleep + 54 3 com.apple.AppKit 0x00007fff94c783e4 -[NSUIHeartBeat _heartBeatThread:] + 2181 4 com.apple.Foundation 0x00007fff8a01be64 NSThreadstart + 1351 5 libsystem_pthread.dylib 0x00007fff9100499d _pthread_body + 131 6 libsystem_pthread.dylib 0x00007fff9100491a _pthread_start + 168 7 libsystem_pthread.dylib 0x00007fff91002351 thread_start + 13
Thread 0 crashed with X86 Thread State (64-bit): rax: 0x00007f9b42db5720 rbx: 0x00007f9b42dc3290 rcx: 0x0000000000000b00 rdx: 0x0000000000000000 rdi: 0x00007f9b42db5720 rsi: 0x0000000000000000 rbp: 0x00007fff5e181f00 rsp: 0x00007fff5e181ef0 r8: 0x0000000000000001 r9: 0x00000000fff00000 r10: 0x00007fff9c68a701 r11: 0x00007fff9ab67431 r12: 0x0000000000000048 r13: 0x00007fff92cfe4c0 r14: 0x00007f9b42dc3290 r15: 0x00000000000000e0 rip: 0x0000000101b8cf93 rfl: 0x0000000000010202 cr2: 0x0000000101b8d0f5
Logical CPU: 1 Error Code: 0x00000000 Trap Number: 6
Binary Images:
0x101a7c000 - 0x101db7ff7 +com.Titan.MilkyTracker (1.00.00) <3A96A4F9-3941-3085-96F4-B7153193F89F> /Applications/MilkyTracker.app/Contents/MacOS/MilkyTracker
0x101e70000 - 0x101ea7fff com.apple.audio.midi.CoreMIDI (1.10 - 88) <51E79766-51D8-3A95-A7FD-18E7E11528F3> /System/Library/Frameworks/CoreMIDI.framework/Versions/A/CoreMIDI
0x101ed1000 - 0x101eeafff libexpat.1.dylib (12.60.1) <6BF318AC-F90F-3F16-99C2-6ADDE404E280> /usr/lib/libexpat.1.dylib
0x1044f3000 - 0x10450efff com.apple.security.csparser (3.0 - 57337.60.2)
External Modification Summary: Calls made by other processes targeting this process: task_for_pid: 6 thread_create: 0 thread_set_state: 0 Calls made by this process: task_for_pid: 0 thread_create: 0 thread_set_state: 0 Calls made by all processes on this machine: task_for_pid: 24524938 thread_create: 0 thread_set_state: 5
VM Region Summary: ReadOnly portion of Libraries: Total=297.6M resident=0K(0%) swapped_out_or_unallocated=297.6M(100%) Writable regions: Total=151.2M written=0K(0%) resident=0K(0%) swapped_out=0K(0%) unallocated=151.2M(100%)
Does the proper release version work?
Yeah, the proper release version can import the samples.
Okay - it's to do with the way the test version I gave you was built, and I think I know why. It's not a bug with the program code, it's actually because the binary I gave you is broken.
I'll provide a fixed binary as soon as I update the build system.
Explanation for devs:
Linking an executable 'A' built for version 'X' of macOS with some static library 'B' built for version 'Y' of macOS can cause a crash when a function from library 'B' is accessed.
In this case: A = MilkyTracker B = liblhasa X = 10.7 Y = 10.12, because libraries obtained from Homebrew are provided compiled only for the target they are being downloaded on. If you're on 10.12, you get 10.12 lhasa/zziplib/etc.
Linker warnings are generated for this, so I was aware of it possibly being a problem.
Solution: When providing Mac binaries we will also need to build all dependant libraries for the OS version we are targeting, which is a shame because it means we cannot use the ones Homebrew provide. I'll update the CMake system to fix this shortly.
@xracecar: Please try the following updated package - it includes the graphics fix from before and should correct this problem. milkytracker-1.00.00.dmg.zip
I've rewrote a bunch of build system related stuff so that macOS builds should be working properly now. I'll move the new commits over from my fork once I'm happy with them.
Works perfectly. Thanks again for fixing these bugs!
Awesome! 😃
You're welcome. Nice colour scheme, by the way.
So whenever I try to import a sample, MilkyTracker just closes out. That's all there is to it.
OS: OSX El Capitan