search

mill1000 / midea-msmart

Python library for local control of Midea (and associated brands) smart air conditioners.
MIT License
49 stars 2 forks source link

Property commands do not respect beep setting #119

Closed mill1000 closed 5 months ago

mill1000 commented 5 months ago

Beep is turned off, but the swing positions beep when selecting other options don't.

Originally posted by @parautenbach in https://github.com/mill1000/midea-ac-py/issues/109#issuecomment-2049403385

It appears the property commands are not respecting the beep setting.

mill1000 commented 5 months ago

@parautenbach @v1k70rk4

I've got a potential fix for the beep when changing swing angle.

If you're willing to test you'll need to run this command within your HA environment (generally within the Docker container)

pip install git+https://github.com/mill1000/midea-msmart.git@issue/properties_buzzer
v1k70rk4 commented 5 months ago

Well, this slipped my attention. I run homeassistant under HAOS, and I ran it. I did an HA restart and it still beeps, is there anything else I need to do? I don't know what was supposed to happen :)

mill1000 commented 5 months ago

Thanks for testing. Try checking your logs to see if the new version of msmart-ng was installed.

On HAOS, HA is still running within a docker container. The above command must be run from within the container.

v1k70rk4 commented 5 months ago

In theory, I have logged in with this: docker exec -it homeassistant /bin/bash

And I got this after the script:

homeassistant:/config# msmart-ng -v
msmart version: 2024.3.3.dev1+ge9a72cf
mill1000 commented 5 months ago

Ok it looks like it took. Does the home-assistant.log report the same version?

v1k70rk4 commented 5 months ago

I made a mistake according to the logs... I installed the HA Core 2024.5.0b4 version along with msmart-ng and then rolled back to the previous version because the Xiaomi devices weren't working... and this also rolled back the msmart.

So, I'm happy to report that with this version, the air conditioner is silent :)

mill1000 commented 5 months ago

Well that's excellent news! I'll get the PR merged and a new version out soon.

parautenbach commented 4 months ago

I can confirm that my beeps in this case are gone. :-) Thanks!

(PS: I've spent some time on my back, so I wasn't able to do much to help, unfortunately.)

mill1000 commented 4 months ago

Thanks for confirming. Hope you are feeling better.