Ein:stop does not stop kernel on Windows

millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs

http://millejoh.github.io/emacs-ipython-notebook/

GNU General Public License v3.0

1.47k stars 122 forks source link

Ein:stop does not stop kernel on Windows #666

Closed 2old2randr closed 4 years ago

2old2randr commented 4 years ago

Signals are sent to the kernel process but this doesn’t seem to stop the kernel under Windows 10. Older versions of the code had a special branch for windows in ein:Jupiter-server-stop that has been removed.

dickmao commented 4 years ago

Commit 6121536

The most celebrated answer in https://github.com/jupyter/notebook/issues/2844 is to dash-nine the pid on Win10. Please let me know if that works since I don't have a Win10 setup.

2old2randr commented 4 years ago

Yes, this seems to work. Thank you.