search

millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs
http://millejoh.github.io/emacs-ipython-notebook/
GNU General Public License v3.0
1.47k stars 122 forks source link

Avoid using fundamental-mode for output #729

Closed digikar99 closed 4 years ago

digikar99 commented 4 years ago

I'd like to use visual-line-mode to display the output - as well as avoid linum-mode being toggled on and off as I move in and out of the output cells. Turned out that fundamental-mode is being used for the output cells. And https://emacs.stackexchange.com/questions/16693/auto-enable-minor-modes-in-fundamental-mode suggests to avoid using fundamental mode. Can a different mode be used - say, text-mode?

dickmao commented 4 years ago

One argument against text-mode is tabular data needing to be strictly aligned with column headings. Apart from that, EIN requires output cells be no-frills as possible as polymode already pushes things to an unhealthy, buggy extent. In fact, we explicitly disable visual-line-mode when we see it to reduce variance.

https://github.com/millejoh/emacs-ipython-notebook/blob/10c1111c8109156a7dbd892687bee977a2ee4596/lisp/poly-ein.el#L280

dickmao commented 4 years ago

We already disable display-line-numbers-mode but apparently linum-mode needs deactivating also e60813e.