search

millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs
http://millejoh.github.io/emacs-ipython-notebook/
GNU General Public License v3.0
1.47k stars 123 forks source link

code compleation with ein-completer.el #807

Closed haschka closed 3 years ago

haschka commented 3 years ago

I'm on version 0.16.2.3 from melpa stable.

After this last update I had serious troubles with the code completer and i saw that here in git the code seems to be completely removed.

I took the version of the ein-completer.el from the commit below and replaced the code of version 0.16.2.3 after I tried hacking it myself and getting the errors away.

https://github.com/millejoh/emacs-ipython-notebook/commit /bcf1c2ac5538cd20a8cea87a071dcb16d64f0b38

I'm a huge fan of this feature and may be others are too. I do like to use elpy for this as it needs its own python environment in my home and pip installs packages, which I find a bit overkill as these functionality is already provided by the jupyter kernel. I also really do not understand why the same is true for jedi.el, even though I have jedi installed on my machine. Thus I really prefere and kind of depend on this feature.

As such I hope that this feature comes back and hope that in writing this issue I can help others reverting to "existed functionality".

my jupyter --version jupyter core : 4.7.1 jupyter-notebook : 6.4.0 qtconsole : not installed ipython : 7.25.0 ipykernel : 5.5.4 jupyter client : 6.1.12 jupyter lab : not installed nbconvert : 6.0.7 ipywidgets : 7.6.3 nbformat : 5.1.3 traitlets : 5.0.5

Thanks, Thomas

dickmao commented 3 years ago

I don't intend on bringing it back. My expert opinion is remote completions are a very difficult thing to do tastefully. Some will disagree. Some will disagree my opinion is expert.

haschka commented 3 years ago

As far as I understand it jedi / elpy is also remote ( installing a code completion server locally )

Maybe we can find a maintainer or someone who helps you out on this issue.

cheers,

Le lun. 6 sept. 2021 à 01:29, dickmao @.***> a écrit :

I don't intend on bringing it back. My expert opinion is remote completions are a very difficult thing to do tastefully. Some will disagree. Some will disagree my opinion is expert.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/millejoh/emacs-ipython-notebook/issues/807#issuecomment-913246375, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACPLY77LCXGHEMSOKMTXEXDUAP4M5ANCNFSM5DPISSVA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

dickmao commented 3 years ago

As far as I understand it jedi / elpy is also remote ( installing a code completion server locally )

Correct, and most people find elpy/Jedi completion unreliable.