millejoh / emacs-ipython-notebook

Jupyter notebook client in Emacs
http://millejoh.github.io/emacs-ipython-notebook/
GNU General Public License v3.0
1.47k stars 123 forks source link

Refine regex expression when checking API version #811

Closed martin-liu closed 2 years ago

martin-liu commented 2 years ago

I tried several different versions of jupyter lab, and found there're 2 different descriptions: description: Server API and description: Notebook API

See https://github.com/jupyter/notebook/blob/master/notebook/services/api/api.yaml#L1-L5 And https://github.com/jupyter-server/jupyter_server/blob/master/jupyter_server/services/api/api.yaml#L1-L5

So refine the regex expression to accommodate it.

dickmao commented 2 years ago

You are rocking my world.