Add osx-arm64/native - Githubissues

milleniumbug / NativeFileDialogSharp

Cross-platform native file dialogs for C#

zlib License

26 stars 6 forks source link

Add osx-arm64/native #2

Open kaylumah opened 1 year ago

kaylumah commented 1 year ago

Add build/lib/Release/arm64/libnfd.dylib

Followed instructions from https://github.com/milleniumbug/NativeFileDialogSharp/issues/1#issuecomment-1474521250

IceReaper commented 1 year ago

Would it be bloated to also add Linux arm64? :)

milleniumbug commented 1 year ago

Not much bloat involved to be honest, especially since users of the library can use appropriate options to not ship libraries for platforms they don't support;

The biggest issue that prevents me from merging this (and also adding support for linux-arm64) is that I have to recompile for every platform involved, as the osx-arm64 uses a newer version of the native library than the other platforms, and this will make for inconsistent behaviour between osx-x64 and osx-arm64.

Ideally this repo should

either have a CI/CD setup so it can adapt to potential future changes to the native library
or even delegate the responsibility of making shared libraries of the native code upstream

IceReaper commented 1 year ago

Good point on the CI solution. that would be to prefer. Im basicaly trying to use this library here https://github.com/OpenRA/OpenRA/pull/20789 which is blocked mostly due to the missing natives currently.

kaylumah commented 1 year ago

Could this be merged if we follow the same instruction on a osx-x64 or is it then still blocked for the diff between Mac and linux/windows?

milleniumbug commented 5 months ago

Been neglecting this one for a while, sorry about that.

Yeah, I'll need the osx-x64 version too as I lost my hackintosh virtual machine. I'll try to build Linux and Windows versions next weekend.

kaylumah commented 5 months ago

No problem at all :) Unfortunately I no longer have a non-ARM Mac available, so I cannot provide the x64 MacOs binaries myself