search

millermedeiros / amd-utils

modular JavaScript utilities written in the AMD format
http://millermedeiros.github.com/amd-utils
142 stars 11 forks source link

Add object size. #32

Closed satazor closed 12 years ago

satazor commented 12 years ago

I know that doing object keys / values and getting the length of the array could be used to get an object size, but we would be populating an useless array, wasting memory. Also it's performance is worst compared to this function.

I made node build.js but I don't what I really know wthat to commit from the _build and doc folder, as it overwrote some url's in the sidebar.html (e.g.: object.html to _build\doc\content\object.html)

Also I didn't know what to insert in the @author and @version tags

millermedeiros commented 12 years ago

@author is your name (since you wrote it) and version I usually start at 0.1.0 + date (so people know if they have an outdated version) like on object/keys.

I will merge it for sure, never added it because I never needed it. Still need tests and documentation, I'm busy right now but don't worry, if you don't do it I will do it in the next days and merge it.

Thanks and keep the good work!

satazor commented 12 years ago

Allright I will make a commit with it fixed and tests added. Still, the _build and doc folder should be committed?

millermedeiros commented 12 years ago

yes, I'm commiting everything so the user can check the docs offline and the _build also contains the source files of the documentation

to update the test runner just need to run node build. It will check all the source files and folders, create a separate tests/spec/spec-XXX.js and tests/spec/XXX for each folder, and than add all the source files to the dependency list, you just need to create a new tests/spec/object/spec-size.js file and populate it.

this same command also generates the documentation.

thx!

satazor commented 12 years ago

Ok it's done. Though I can't generate the documentation because of this error:

Error: ENOENT, no such file or directory 'some_folder\amd-utils\doc_build\doc\content'

millermedeiros commented 12 years ago

strange, doc was generated at first try for me.. I also just added all the node_modules to the repository since they are needed to generate the docs and specs. Maybe it was some dependency issue or running the build from a different path than the repository root. Thanks for the pull requests!!