millermedeiros / amd-utils

modular JavaScript utilities written in the AMD format
http://millermedeiros.github.com/amd-utils
142 stars 11 forks source link

queryString methods doesn't follow argument convention #79

Closed millermedeiros closed 12 years ago

millermedeiros commented 12 years ago

almost all the methods on amd-utils receives the target as first argument, hasParam and getParam receives the URL as second argument (optional) and goes against the convention.

I also think that it shouldn't use window.location.href by default, user should explicitly pass the URL, too much magic is a bad thing and behavior will differ on node.js.