search

millermedeiros / esformatter

ECMAScript code beautifier/formatter
MIT License
970 stars 91 forks source link

Multiline comment inside JSX expression causes error #427

Closed ckknight closed 8 years ago

ckknight commented 8 years ago

Input:

class MyThing extends Component {
  render() {
    return (
      <div>
        {/* some comment */}
        <span />
      </div>
    );
  }
}

Result:

TypeError: Cannot read property 'value' of undefined
    at getParentheses (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/hooks/expressionParentheses.js:26:66)
    at Object.addSpaceInsideExpressionParentheses [as addSpaceInside] (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/hooks/expressionParentheses.js:10:21)
    at transformNode (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/transform.js:78:25)
    at Array.forEach (native)
    at Object.moonwalk (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/rocambole/rocambole.js:432:11)
    at transform (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/transform.js:37:13)
    at doFormat (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/format.js:130:3)
    at Object.format (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/format.js:44:9)
    at formatToSelf (/Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/cli.js:233:40)
    at /Users/ckknight/Development/SpaceViewInc/space.vu/node_modules/esformatter/lib/cli.js:94:7