does esformatter support .eslintignore?

millermedeiros / esformatter

ECMAScript code beautifier/formatter

MIT License

970 stars 91 forks source link

does esformatter support .eslintignore? #449

Open gaboesquivel opened 8 years ago

gaboesquivel commented 8 years ago

Hi, It seems to me to me that esformatter is not ignoring files listed in .eslintignore Does it support .eslintignore or you always need to ignore in the glob ?

millermedeiros commented 8 years ago

it doesn't support it. but we should improve the way we filter out files. see: https://github.com/millermedeiros/esformatter/issues/329#issuecomment-133021022

millermedeiros commented 8 years ago

I added basic support for --ignore in the CLI (https://github.com/millermedeiros/esformatter/commit/ebc469fba85fb60aab72d328d33e5c957b3b3e6c), but we still don't have any logic in place to read .eslintignore, .gitignore, etc...

This is not on my hi-pri list for now (meaning I won't work on this until I fix everything that is on the v0.10.0 milestone), but it's definitely a nice to have; Pull requests are highly appreciated!

gaboesquivel commented 8 years ago

great thanks