search

millermedeiros / js-signals

Custom Event/Messaging system for JavaScript inspired by AS3-Signals
http://millermedeiros.github.com/js-signals/
1.97k stars 179 forks source link

make `isDef()` private #14

Closed millermedeiros closed 13 years ago

millermedeiros commented 13 years ago

no point on making it public.. users shouldn't count on it. this feature is completely unrelated to the library purpose.

millermedeiros commented 13 years ago

instead of making it private, it would be better to delete it and just compare to void(0)... it's only being called twice and the method doesn't make code cleaner..

millermedeiros commented 13 years ago

fixed on commit a724d6d24951bb0b2d30d8775806f85280692f48