search

millermedeiros / js-signals

Custom Event/Messaging system for JavaScript inspired by AS3-Signals
http://millermedeiros.github.com/js-signals/
1.97k stars 179 forks source link

use a public property to enable/disable signal/binding instead of methods #19

Closed millermedeiros closed 13 years ago

millermedeiros commented 13 years ago

at the beginning I wasn't sure how the code would evolve and decided to wrap access to the _isEnabled property (to increase flexibility) but I don't see any reason for keeping it since they are just setting/getting boolean values and could be simplified to a single boolean property.

until now best name seems to be active since it represents estate, don't confuse with an action call or a signal name.

millermedeiros commented 13 years ago

implemented on commit 77cb7934a72122b4ff92a41aa048028a08cb62b0