millermedeiros / js-signals

Custom Event/Messaging system for JavaScript inspired by AS3-Signals
http://millermedeiros.github.com/js-signals/
1.97k stars 179 forks source link

remove `dispose` method from `SignalBinding` since `detach` does the same thing #27

Closed millermedeiros closed 13 years ago

millermedeiros commented 13 years ago

the SignalBinding already have the detach method which does exactly the same thing - code is even duplicated ( _destroy is already being called by Signal during removal)

maybe keep it just for consistency - since Signal also have a dispose method - but make it be just an alias to the detach method and document that it is just an alias.

so far I think it is better to just kill it completely, detach is a better name anyway and I doubt that a lot of people is using it.