the SignalBinding already have the detach method which does exactly the same thing - code is even duplicated ( _destroy is already being called by Signal during removal)
maybe keep it just for consistency - since Signal also have a dispose method - but make it be just an alias to the detach method and document that it is just an alias.
so far I think it is better to just kill it completely, detach is a better name anyway and I doubt that a lot of people is using it.
the
SignalBinding
already have thedetach
method which does exactly the same thing - code is even duplicated (_destroy
is already being called bySignal
during removal)maybe keep it just for consistency - since
Signal
also have adispose
method - but make it be just an alias to thedetach
method and document that it is just an alias.so far I think it is better to just kill it completely,
detach
is a better name anyway and I doubt that a lot of people is using it.