millerse / US-National-Parasite-Collection

0 stars 0 forks source link

accession numbers truncated? #5

Open jhpoelen opened 6 years ago

jhpoelen commented 6 years ago

In reviewing https://github.com/jhpoelen/eol-globi-data/issues/307#issuecomment-322831523 , I noticed that cleaned_up.tsv contains accession 98139 for GUID E387E263-1EE3-426B-8692-A0FB17D7BA4E. However, in the original data, accession 098139.00 is used.

It seems that the original accession is interpreted as a number, where it probably should not be.

@millerse @jhammock curious to hear your thoughts on this.

jhammock commented 6 years ago

Yes, this has happened to accession numbers before in interfaces that try to help (excel, etc). Strings like that should be interpreted as text.

Hi, Sarah! If you have access and capacity to look into this, please do. I trust the new gig is going well :) If you need input about tracking hours and invoicing while working more intermittently, let's arrange a time to chat.

On Tue, Nov 14, 2017 at 12:45 PM, Jorrit Poelen notifications@github.com wrote:

In reviewing jhpoelen/eol-globi-data#307 https://github.com/jhpoelen/eol-globi-data/issues/307 , I noticed that cleaned_up.tsv http://../blob/master/cleaned_up.tsv contains accession 98139 for GUID E387E263-1EE3-426B-8692-A0FB17D7BA4E. However, in the original data, accession 098139.00 is used.

It seems that the original accession is interpreted as a number, where it probably should not be.

@millerse https://github.com/millerse @jhammock https://github.com/jhammock curious to hear your thoughts on this.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/millerse/US-National-Parasite-Collection/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4uh_ShIRKdZq779f3XjPePIHjh4Yknks5s2dGsgaJpZM4Qduzb .