search

milli0n / rainmeter

Automatically exported from code.google.com/p/rainmeter
0 stars 0 forks source link

Broken function: !Execute [[Measure]] #110

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Example:
LeftMouseUpAction=!Execute [[MeasureURL]]

This syntax no longer works unless the meter or measure has
DynamicVariables=1. This is probably the result of a change from either
r217 or r224.

Original issue reported on code.google.com by Kae...@gmail.com on 21 Sep 2009 at 6:35

GoogleCodeExporter commented 8 years ago 
Verified in Vista 64bit and 7 64bit.

It will be in the latest Beta as this does not happen in r213.

Original comment by evmckay on 21 Sep 2009 at 10:52

GoogleCodeExporter commented 8 years ago 
At this stage, the behavior follows issue 101.
And because the first element had not been replaced due to the bug, and I made a
change on r217 to follow the behavior strictly.
( - Fixed: Multibang [] not assumed when [Measure] is replaced in
CConfigParser::ReadString(). )

For instance,
----------
Config:
LeftMouseDownAction=!Execute
["http://www.google.com/search?&q=[Hours]:[Minutes]:[Seconds]"]

r213 with DynamicVariables=0:
LeftMouseDownAction=!Execute ["http://www.google.com/search?&q=[Hours]:00:00"]
(Only [Hours] is replaced to the correct value when executing this action.)

r213 with DynamicVariables=1:
LeftMouseDownAction=!Execute ["http://www.google.com/search?&q=12:49:42"]

r217 with DynamicVariables=0:
LeftMouseDownAction=!Execute ["http://www.google.com/search?&q=00:00:00"]

r217 with DynamicVariables=1:
LeftMouseDownAction=!Execute ["http://www.google.com/search?&q=12:49:42"]
----------
----------
Config:
LeftMouseUpAction=!Execute [[MeasureURL]]

r213 with DynamicVariables=0:
LeftMouseUpAction=!Execute [[MeasureURL]]
(Only [MeasureURL] is replaced to the correct value when executing this action.)

r213 with DynamicVariables=1:
LeftMouseUpAction=!Execute [http://correct-url]

r217 with DynamicVariables=0:
LeftMouseUpAction=!Execute []

r217 with DynamicVariables=1:
LeftMouseUpAction=!Execute [http://correct-url]
----------

However, I do not like this behavior.
If possible, we should take compatibility with the behavior before.
E.g. for XXXAction, [Measure] is not replaced when reading the skins.

Original comment by spx268 on 22 Sep 2009 at 4:46

GoogleCodeExporter commented 8 years ago 
Broken backwards compatibility was fixed on r236.

Original comment by spx268 on 1 Oct 2009 at 3:15