search

milliHQ / terraform-aws-next-js-image-optimization

A drop-in image optimization loader for Next.js image component powered by AWS Lambda.
https://registry.terraform.io/modules/milliHQ/next-js-image-optimization/aws
Apache License 2.0
105 stars 18 forks source link

Usage of ACM certificate instead of CloudFront #134

Closed 3h4x closed 2 years ago

ofhouse commented 2 years ago

Hi, the changes proposed in your PR are too opinionated:

Adding these settings as optional parameters would work, but we don't want to force our users into using a custom domain.

3h4x commented 2 years ago

Hi, the changes proposed in your PR are too opinionated:

  • The CloudFront distribution would only work with custom domains
  • The CloudFront distribution would only work with custom certificates

Adding these settings as optional parameters would work, but we don't want to force our users into using a custom domain.

I totally agree. Unfortunately I dont have time to improve it. I thought to push PR and even if it gets rejected it will leave a trace so other people could eventually pick it up.

ofhouse commented 2 years ago

@3h4x Thanks for clarifying! Will try to pick this up for one of the next releases.

ofhouse commented 2 years ago

This has been released in v12.1.3. Thanks for contributing!