Closed florentmaitre closed 8 months ago
Hi sorry for the late reply, for some reason I don't get automatic emails when issues are posted here.
@codlab can you take a look at these logs? There was state change management change introduce for Android between 1.7.2 -> 1.7.3. I think those may have inadvertently caused this. I will send you the commits in messages.
From the logs, there are 2 possibilities. One that I'd like to be sure of, @florentmaitre can you check that for any reason, the sdk or the app was not forcing the coroutineScope calling the launch to be canceled which means that the stop
being logged was not followed by an actual attempt to disconnect()
A breaking point on the subscriber.disconnect() should suffice or changing the order with
fun stop() {
coroutineScope.launch {
Log.d("Millicast", "stop")
subscriber.disconnect()
Log.d("Millicast", "stopped")
}
}
I'll test rn for the possibility that it's internal
We indeed have an issue that is related to the changes in the state but this also hides something which was used as a feature in this snippet. This will likely change in future version of the sdk but for now a 1.8.1 is scheduled to be released without any modifications in behaviour - so normally there will be no changes required in the above code
Issue has been fixed with 1.8.1 release: https://github.com/millicast/millicast-native-sdk/releases/tag/v1.8.1. There is some issue with Sonatype so the publishing of Android artifacts there is encountering some issues. We will keep this ticket open until we can publish to Maven repo. @codlab FYI
The 1.8.1 containing the fix for android is live and can be used right away (edit: no changes in the API are expected so it should be working by just updating the referenced version)
Issue is fixed on our side with 1.8.1. Thank you 👍
My team and I are using the Android SDK and we encounter an issue with the auto reconnect feature of a subscriber since version 1.7.3.
When this feature is enabled and the subscriber tries to reconnect to the Millicast platform, then the connection cannot be stopped and the subscriber tries to reconnect forever.
Here is a simple sample code which illustrates the issue:
And here are the associated logs:
1.7.2 (OK)
1.7.3 (KO)
1.8.0 (KO)
Are we doing something wrong or is this a regression? Thanks for you help