millicast / millicast-native-sdk

SDK to build native clients using the Millicast platform.
Other
17 stars 5 forks source link

[iOS] Add M1 Support #5

Closed yoojinsca closed 2 years ago

yoojinsca commented 2 years ago

For iOS, please provide support for the Simulator on M1 Macbooks.

The sample project does not build for Simulators on M1 Macbooks. https://github.com/millicast/Millicast-ObjC-SDK-iOS-Sample-App-in-Swift commit: c10a2487e0ce881d2b59f26d9d85cc459ed1746d

The sample project does build for non-M1 Macbooks.

ie. iPhone 13 Simulator

Error:

Undefined symbols for architecture arm64:
  "_OBJC_CLASS_$_MCSubscriberCredentials", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCPublisherCredentials", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCAudioSource", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCClientOptions", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCPublisher", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCAudioTrack", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCSubscriber", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCVideoTrack", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCIosVideoRenderer", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCMedia", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCVideoCapabilities", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCVideoSource", referenced from:
      objc-class-ref in MillicastManager.o
  "_OBJC_CLASS_$_MCLayerData", referenced from:
      objc-class-ref in SubListener.o
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
yoojinsca commented 2 years ago

sorry not too sure who to discuss with so bumping @murillo128 Our team is getting more M1 Macbooks so this is getting more important for us.

dzeitman commented 2 years ago

@yoojinsca - We recently added support for the simulator on M1 Macs in version 1.3.0 of the SDK. please update your project's package settings to pull down latest version of the SDK. That should resolve your issue.

yoojinsca commented 2 years ago

awesome! thank you! woo hoo.

I can confirm it works on my M1 simulator.

yoojinsca commented 2 years ago

btw the release notes seem to be missing this