search

millicast / millicast-player-unreal-engine-plugin

Millicast Player plugin for Unreal Engine
Other
19 stars 15 forks source link

Plugin no longer compiles on Linux #37

Closed adrian-j-programmer closed 1 year ago

adrian-j-programmer commented 1 year ago

When building the plugin in official UE5.1 linux container (and locally on a linux machine), the build fails because of the PLATFORM_XBOXONE define in the PCH. The quick workaround for us was to comment out this platform define, but it's probably not the right call.

Here's the build error:

[3/83] Compile PCH.MillicastPlayer.h
In file included from /project/Plugins/MillicastPlayer/Intermediate/Build/Linux/B4D820EA/UnrealEditor/Development/MillicastPlayer/PCH.MillicastPlayer.h:383:
/project/Plugins/MillicastPlayer/Source/MillicastPlayer/Private/PCH.h:52:25: error: 'PLATFORM_XBOXONE' is not defined, evaluates to 0 [-Werror,-Wundef]
#if PLATFORM_WINDOWS || PLATFORM_XBOXONE
dzeitman commented 1 year ago

@adrian-j-programmer - Thanks for the feedback; @dbaldassi may be able to expand on what additional features defined in the PCH that are supported by our platform on Linux. In the meantime, we appreciate the suggested workaround.

dbaldassi commented 1 year ago

I actually removed completly the PCH file to sync with the publisher plugin. It should now compile on Linux. I didn't test yet to compile on Linux but will do.