search

millicast / millicast-player-unreal-engine-plugin

Millicast Player plugin for Unreal Engine
Other
19 stars 15 forks source link

5.1 Build Error #43

Closed MaxDorn96 closed 1 year ago

MaxDorn96 commented 1 year ago

I get a build error when trying to create a Linux Server

In file included from ProjectDir/Intermediate/Build/Linux/B4D820EA/ProjectServer/Development/MillicastPlayer/Module.MillicastPlayer.cpp:24: ProjectDir\Project\Plugins\Millicast\Source\MillicastPlayer\Private\WebRTC\PeerConnection.cpp(219,49): error: 'OnFailureCallback' is a private member of 'Millicast::Player::detail::TSessionDescriptionObserver' std::ref(LocalSessionDescription->OnFailureCallback)); ^ ProjectDir\Plugins\Millicast\Source\MillicastPlayer\Private\WebRTC\SessionDescriptionObserver.h(19,40): note: implicitly declared private here TFunction<void(const std::string&)> OnFailureCallback; ^ In file included from ProjectDir/Intermediate/Build/Linux/B4D820EA/ProjectServer/Development/MillicastPlayer/Module.MillicastPlayer.cpp:24: ProjectDir\Plugins\Millicast\Source\MillicastPlayer\Private\WebRTC\PeerConnection.cpp(232,50): error: 'OnFailureCallback' is a private member of 'Millicast::Player::detail::TSessionDescriptionObserver' std::ref(RemoteSessionDescription->OnFailureCallback)); ^ ProjectDir\Plugins\Millicast\Source\MillicastPlayer\Private\WebRTC\SessionDescriptionObserver.h(19,40): note: implicitly declared private here TFunction<void(const std::string&)> OnFailureCallback;

dbaldassi commented 1 year ago

It is now fixed

MaximeM commented 1 year ago 
In file included from E:\Proj/Plugins/MillicastPlayer/Intermediate/Build/Linux/B4D820EA/UnrealGame/Development/MillicastPlayer/Module.MillicastPlayer.cpp:23:
UATHelper: Packaging (Linux): E:\Proj\Plugins\MillicastPlayer\Source\MillicastPlayer\Private\WebRTC\MillicastMediaTracks.cpp(22,4): error: expected expression
UATHelper: Packaging (Linux):                         UE_LOG(LogMillicastPlayer, Verbose, TEXT("This video track is no more valid."),);
UATHelper: Packaging (Linux):                         ^
UATHelper: Packaging (Linux): E:\EpicGames\UE_5.1\Engine\Source\Runtime\Core\Public\Logging\LogMacros.h(255,4): note: expanded from macro 'UE_LOG'
UATHelper: Packaging (Linux):                         UE_INTERNAL_LOG_IMPL(CategoryName, Verbosity, Format, ##__VA_ARGS__); \
UATHelper: Packaging (Linux):                         ^
UATHelper: Packaging (Linux): E:\EpicGames\UE_5.1\Engine\Source\Runtime\Core\Public\Logging\LogMacros.h(227,43): note: expanded from macro 'UE_INTERNAL_LOG_IMPL'
UATHelper: Packaging (Linux):                                 }, CategoryName, Format, ##__VA_ARGS__); \
UATHelper: Packaging (Linux):                                                                       ^
UATHelper: Packaging (Linux): 1 error generated.
UATHelper: Packaging (Linux): [3/4] Link (lld) OmegaPark cancelled
UATHelper: Packaging (Linux): [4/4] WriteMetadata OmegaPark.target cancelled
PackagingResults: Error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
PackagingResults: Error: expected expression

Still problem packaging for linux client on dev branch :)

MaximeM commented 1 year ago

Commenting that log helped. Not sure why tht namespace won't work for linux .

dbaldassi commented 1 year ago

That is not the same error, not sure why it is happening, I didn't have this when compiling for linux and that file did not change. I'll take a look

dbaldassi commented 1 year ago

Well this should be fixed now in dev 86c0660 It was just an additional comma at the end of the UE_LOG. Not sure how it compiled on windows

MaxDorn96 commented 1 year ago

I've updated the Plugin and I was able to build on Linux Server as well as Windows Client without any more Problems, thanks a lot