millicast / millicast-publisher-unreal-engine-plugin

Unreal engine to stream game content to millicast platform.
Other
21 stars 12 forks source link

Added missing includes & Forward declared types #66

Open gmpreussner opened 6 months ago

gmpreussner commented 6 months ago

The main change here is the addition of ISubmixBufferListener.h in order to unblock 5.3.2 compilation. However, I took the liberty to improve the rest of the file as well to demonstrate proper IWYU principles:

A lot of studios (and some individual developers like me) use non-unity builds, which are much more sensitive to incorrect dependency handling. Unity builds are very forgiving, because many files get gobbled together into a single compilation unit, and more likely than not the dependencies end up being included one way or another; that's not best practice though.

Most other Millicast headers could use a cleanup pass in this respect as well.

grantwilk commented 5 months ago

@dbaldassi Please take a moment to review this when you can, thank you. This blocks 5.3.2 compilation.

Also, @gmpreussner is a certified Unreal Engine whiz, his advice should definitely be taken here for future reference.