search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
37 stars 26 forks source link

Add description of DTX purpose #302

Closed Santiago-Souto closed 5 months ago

Santiago-Souto commented 6 months ago

Also, fix typos & update docs

R-Delfino95 commented 5 months ago

Comments are looks good to me. But should we also review the translation json files? If not, Could we ignore the generated translation folder docs-translations?

In the deployment the workflow generates the translation folder. I think It's not necessary to build it each time we modify the docs. We could add the doc-translation to .gitignore and remove the folder.

Santiago-Souto commented 5 months ago

I left #305 open to remove this unnecessary directory. Thanks @vincentsong for pointing it out! Once that is merged we will pull develop and remove does changes.