search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
37 stars 29 forks source link

Throw error when simulcast cannot be set due to compatibility #344

Closed Santiago-Souto closed 5 months ago

Santiago-Souto commented 5 months ago

@dubeyShivank / @j12y we should review if you should throw an error and prevent from connecting or log the error and continue without setting simulcast.

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: d223dcdd8b9093c11bb0c176c1fd4cf5b8b55428

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Santiago-Souto commented 5 months ago

@j12y I also changed the warning for codecs to match your proposal of browsers, please have a look at it as well

dubeyShivank commented 5 months ago

LGTM :)