search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
37 stars 29 forks source link

Typescript definitions for diagnose #345

Closed dubeyShivank closed 5 months ago

dubeyShivank commented 5 months ago

@Santiago-Souto hoping this is what I need to be doing for ts support?

changeset-bot[bot] commented 5 months ago

⚠️ No Changeset found

Latest commit: c7a4ab6a29812a5b10ab8edb41fc7aa77cefa284

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Santiago-Souto commented 5 months ago

It is the way to go yes! I just do not think the changeset should the created here, as the feature/change is in the stats branch, and this is just an add-on to that

dubeyShivank commented 5 months ago

Ok I can remove the changeset, thanks!

Santiago-Souto commented 5 months ago

Should we create a type for the config object?

Santiago-Souto commented 5 months ago

Should PeerConnectionStats be updated as well?

dubeyShivank commented 5 months ago

Should PeerConnectionStats be updated as well?

I'll do both, thanks!