search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
37 stars 26 forks source link

Fix / All sources not shown when multiview enabled #355

Closed Santiago-Souto closed 1 month ago

Santiago-Souto commented 1 month ago

~Change this.worker variable for this.workers object in View js for handling multiple source streams. Each key correspond to its mid value.~ In order for the View instance to handle multiple source streams tracks (video and audio), every incoming track is used to create an encoded stream and passed it through the worker to process it. To maintain knowledge of which track is which, the transceiver's mid value is saved with the encoded stream created.

Additionally, add publisher demo sourceId query param for multisource publishing and expose millicastView in multiview demo

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: f6cb4e322f7d0e1d421d2283b3f9f56262d1a22a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vincentsong commented 1 month ago

Change this.worker variable for this.workers object in View js for handling multiple source streams. Each key correspond to its mid value.

Additionally, add publisher demo sourceId query param for multisource publishing and expose millicastView in multiview demo

Do you need to update this description? I didn't find this.workers, it's still using this.worker