Add optional chaining operator to string method that can be undefined

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.

Other

37 stars 29 forks source link

Add optional chaining operator to string method that can be undefined #361

Closed Santiago-Souto closed 4 months ago

Santiago-Souto commented 4 months ago

In Safari, payloadType is undefined, so it needs a null-safe operator to avoid run time errors.

How to test it:

Run npm ci in the root folder.
Make sure to have the tokens and vars set in .env files.
Run npm run start to run all packages.
Publisher app will pop up in the browser (localhost:10001). Start to publish a stream.
Open viewer app in Safari browser to start viewing the published stream. No error should pop up and audio/video should be seen/heard.

changeset-bot[bot] commented 4 months ago

⚠️ No Changeset found

Latest commit: 556e1ab7c3d0038ad6170b1cdf641122ce9aa3b6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR