search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
39 stars 30 forks source link

Fix lint #450

Closed gregdolby closed 1 month ago

gregdolby commented 1 month ago

This is a a fully converted TS SDK which builds/tests/starts and lints.

@Santiago-Souto could you take a good look over TransformWorker.worker.ts and Codecs.ts. I tried my best at typing those files using WebRTC type from MDN and reverse engineering the data in these files but I'm still not 100%.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: b759d9891fd3c12f0ceb903e19e410ad876fb25b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gregdolby commented 1 month ago

Sample apps are not working but probably due to being in TS not fully converted

Sample apps should be working. Try runing 'nx reset' delete node_modules and package-lock. Also be sure to delete all node_modules in pacakges. The only node_modules that exist any more are in project root. I just validated that the apps work