refactor: reduce bundle size

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.

Other

39 stars 30 forks source link

refactor: reduce bundle size #453

Open gregdolby opened 1 month ago

gregdolby commented 1 month ago

Removed 'joi'
created custom publish options validation (our joi validation wasn't doing much in the first place, just warnings. all undefined properties would be validated)
added tests for custom validation
removed excess bundled files. only es module build with types exists now

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: cf7163322b7bc990830c456c86f4a08ae448b379

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

gregdolby commented 1 month ago

I am working through this e2e test failure and it has to do with the build output. Puppeteer needs umd build but I am trying to figure out how to get it to work with es module bundle.

gregdolby commented 1 month ago

I ended up adding umd bundle back. Jest tests and puppeteer run in node and they both support esm but for jest it is experimental.