search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
39 stars 30 forks source link

Call subscribe again when there is no cached DRM profile #456

Closed vincentsong closed 1 month ago

vincentsong commented 1 month ago

We need to reproduce the issue when open viewer before broadcast start, the first 'subscrbe' API returned 200 response without DRM profile, when 'active' event comes we need to invoke 'subscdribe' API again.

But I cannot reproduce that case, since the 'subscribe' API always return 400 now.

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 6fea845ba5305bc94500bd4ea8d132ee9230f2fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vincentsong commented 1 month ago

We need to reproduce the issue when open viewer before broadcast start, the first 'subscrbe' API returned 200 response without DRM profile, when 'active' event comes we need to invoke 'subscdribe' API again.

But I cannot reproduce that case, since the 'subscribe' API always return 400 now.

We changed the logic, only use the drmObject from 2nd subscribe endpoint's response. So we could verify it is working

Note: this is a patch, we should use the drmObject from active event in next release