search

millicast / millicast-sdk

SDK for building a realtime broadcaster using the Millicast platform.
Other
39 stars 30 forks source link

Fix the acceptable value types for sourceId to ensure consistency. #476

Closed snoh666 closed 2 weeks ago

snoh666 commented 3 weeks ago

In regards to my question issue #471 adding updated docs and types

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 0253aeb3bf1132e1e13e7b6630af023c515819cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | -------------- | ----- | | @millicast/sdk | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Santiago-Souto commented 2 weeks ago

Hey @snoh666 ! Thanks for the contribution! Could you remove the bump version and instead create a changeset file with the change message?

snoh666 commented 2 weeks ago

Sure @Santiago-Souto! Changed that :D Probably done something wrong while configuring changeset cli :D

Santiago-Souto commented 2 weeks ago

I am trying to understand why the e2e tests are failing, as your changes do not suggest they should break. Once this is fixed, we can approve the PR