million-views / praas

Proxy as a service.
MIT License
4 stars 2 forks source link

Split proxy server test into test data setup and test script #87

Closed 5r1n1 closed 4 years ago

5r1n1 commented 4 years ago
shinenelson commented 4 years ago

things to do as I see it :

stretch

shinenelson commented 4 years ago

I'm sorry for the commit spam. Following our discussions last evening, I've made the suggested changes from the feedback and gotten the situation to comparable level where I was earlier but this time, based on the suggestions from earlier.

here's where this is at :

  1. the test conduit setup has been moved from the proxy server test suite into the crud server test suite
  2. of the remaining tests that have functional code, 1 pass and 2 fail. The reason for the failures are because the external services are being called and the corresponding services return a HTTP 404.
kavithaii commented 4 years ago

ETA - 24June2020 for task 3, 4, 5 1. Test cases Condition table 2. Finalize test cases

  1. Test data design (WIP)
  2. Write/add test cases functionality to the proxy server.test.js
  3. Or move tests to separate file (name of file need to be decided)
  4. Test run the new test cases
kavithaii commented 4 years ago

@shinenelson Explain why the task has not been completed past the due date? What is the next ETA for this task? List the complete and pending sub-tasks

shinenelson commented 4 years ago

@kavithaii, this issue was technically completed with 5aaaed9 ( #94 ). however, I made a mis-assumption and continued to assume that I was working on this issue when I was actually working on #82 ( I messed up the issue titles in my head ).

( in my opinion, your comment from June 24, 2020 should also have gone to #82 )

while, commits 0fa3291..7c65034 also belong to #82, I mistakenly committed them with the wrong tracking issue number. I will be correcting that and pushing future commits with the correct issue number.