milo2012 / metasploitHelper

metasploitHelper
242 stars 73 forks source link

Msf helper parse nmap #14

Closed Chan9390 closed 7 years ago

Chan9390 commented 7 years ago

After going through the code under parseNmap(filename) I found the following:

The below variables are not used:

Line 205 and 209 uses same code which executes on either conditions The statement is: tmpportsList.append([str(ip),str(services.port),services.protocol,services.service])

My changes:

Chan9390 commented 7 years ago

By the way, I have no clue on why the spaces were deleted. I think my IDE automatically deleted extra spaces at the end of statements.

Chan9390 commented 7 years ago

Will merge ?

milo2012 commented 7 years ago

Merged. Thanks