search

miloaisdino / pe

0 stars 0 forks source link

Bug in date parsing in 'addevent' command #10

Open miloaisdino opened 1 week ago

miloaisdino commented 1 week ago

Screenshot 2024-11-15 at 5.03.28 PM.png

When a user executes addevent sp/BBW t/COM t/BIZ d/2024 02 30 1800 v/USC pa/Muthu which is an invalid date, instead of throwing an error message, the app proceeds to add an event on 2024/02/29 instead without warning. This bug occurs for other months as well.

The event on 2024/02/29 does not exist in real life. Hence this is a major problem as it can lead to users (event organisers) to keep track of the wrong dates and make wrong arrangements.

nus-se-script commented 5 days ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Thank you for this bug report! While we are aware that this bug does cause a minor inconvenience, we would like to point out that this is due to the LocalDateTime format's behavior specified in Java's API.

However, this is type of behavior from the user would be considered uncommon and faulty, and there is a work-around via the editevent command to change to the desired valid date, so we believe this is a severity.Low error. Nonetheless, we could have implemented ways to circumvent this. Thus, we will mark this as accepted!

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: [replace this with your reason]