miloaisdino / pe

0 stars 0 forks source link

Duplicate check does not work for same name with different casing #2

Open miloaisdino opened 1 week ago

miloaisdino commented 1 week ago

Screenshot 2024-11-15 at 4.19.11 PM.png The app allows adding multiple persons with the same name, just different casing. Eg add n/John Doe p/98765432 e/john@mail.com r/athlete - COM - Soccer Men add n/John Doe p/98765432 e/john@mail.com r/Volunteer - Emcee It would be good if a 'near match' warning can be given, as in the real world, names are not expected to be case sensitive.

nus-se-bot commented 1 week ago

Team's Response

Hi, thanks for reporting this! However, this intentional behavior results from two deliberate design decisions:

1) Our names actually are case insensitive, however we allow duplicate names as long as they don't have the same phone number and email. This is due to commonality of certain names among the student population (e.g. there could be multiple Tan Jun Jie's). In your case here, since 8 and 9's email are different, we count them as different people.

2) The reason why only the same PHONE NUMBER does not count as a duplicate is because due to the nature of some contacts being sponsors or vendors with the same business phone number or email, we need to allow these and not consider them as duplicates.

However, your suggested feature of giving a 'near match' warning, while not a specified behavior in our currently supplied version, sounds like a useful feature to implement in a future version! For this, we would like to suggest a response.NotInScope.

Thank you, and hope this helps!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]