milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
916 stars 196 forks source link

WP Debug Notice: Undefined variable: is_IE ? #143

Closed schweigerd closed 11 years ago

schweigerd commented 11 years ago

Hello!

First of all, thank you very much for your great work!

I encountered the following in the front end after installing reverie 4 locally on my XAMPP/Win8 (Browser Chrome/IE10):

Notice: Undefined variable: is_IE in C:\xampp\htdocs\forged\wp-content\themes\reverie-master\lib\clean.php on line 127

I am really new to SASS but managed to get it running. I also located the variable $is_IE, but i have no idea how to fix this?

any help is appreciated, thanks!

rememberlenny commented 11 years ago

I got the same error on OSx and MAMP

Notice: Undefined variable: is_IE in /Users/lkbogdonoff/sites/ai/apache/wp-content/themes/reverie-master/lib/clean.php on line 127

jmccombald commented 11 years ago

I just set the variable right before the conditional statement. Seemed to take care of the error.

global $is_IE;    
if ($is_IE) {
   wp_register_script ( 'html5shiv', "http://html5shiv.googlecode.com/svn/trunk/html5.js" , false, true);
}
rememberlenny commented 11 years ago

I submitted a pull request to resolve this.

@milohuang This thread should be closed.