search

milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
919 stars 196 forks source link

data-equalizer not working #283

Open sanderdewijs opened 10 years ago

sanderdewijs commented 10 years ago

I just found that the data-equalizer function doesn't work in reverie. I have tried to include the foundation.equalizer.js in the functions.js (register_script and enqueue_script) but no success.

Also I have replaced the foundation.min.js file included in Reverie with the latest version from the Foundation website. Also without the desired result.

Can you help me out?

gpspake commented 10 years ago

Whoa! very cool. I didn't even know about that. I've created a fork of Reverie built with Grunt and the latest version of Foundation; I just tested this and it's working. If you want to try it out, check out grunterie.

sanderdewijs commented 10 years ago

Thanks! I'll definitely check that out. The data-equalizer is a great function. I was almost about to give up and use tables :)

gpspake commented 10 years ago

I've actually already found somewhere to use it. Just a note... It took me a few minutes to get it working because I was using it like a class instead of adding it to the element. So I was trying to use it like this:
<div class="row data-equalizer" >
That obviously didn't work but I realized the mistake and changed to the following: <div class="row" data-equalizer>
That fixed it. Simple mistake but I thought I'd share just in case you had the same thing going on.

Granted I was doing this in Grunterie so I can't say I've tested it in Reverie.

harrisrobin commented 10 years ago

data-equalizer is not working for me in Reverie. Has anyone found a fix for this ?

gpspake commented 10 years ago

There are several issues with the latest version of reverie that are mostly because of issues that existed in the version of Foundation it was built with (viewport, sticky nav, and this). A lot of those issues have been fixed in the latest release of Foundation. Zhen's been MIA for a while but I imagine he'll show back up at some point to upgrade Reverie to the latest version of Foundation which will fix a lot of the minor issues people are having.

Until then, if you want to use reverie with the latest version of foundation, try Grunterie. I'm going to try to keep Grunterie at the current versions when they come out. Also, if Zhen updates Reverie, I'll try to port everything over for people who want to use Grunt but you'll still be able to use Compass.

If you're looking for a quick fix, you may want to check out the foundation data-equalizer issues for hints. That's how I figured out how to fix the sticky top bar issue.

harrisrobin commented 10 years ago

Thank you for your reply. I actually ended up using flexbox to achieve what I wanted (same height responsive panels) and it worked perfectly for what I needed :)

Cheers,