search

milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
919 stars 196 forks source link

ie.css #284

Open uphamg opened 10 years ago

uphamg commented 10 years ago

Is this completely obsolete now?

I hate designing and building for IE as much as anybody, but it had to be done. Now though, I'm not seeing ie.css anymore just for a safe backup plan for people still using older versions of the browser ...

Is this completely gone now and if so, what is everybody doing to work around this?

gpspake commented 10 years ago

I was just wondering the same thing yesterday. My theory is this was in an older version from before they dropped old IE support and it never got removed from the theme.

uphamg commented 10 years ago

Well in the clean.php file, it still calls for an ie.css 

// ie-only style sheet
wp_register_style( 'reverie-ie-only', get_template_directory_uri() . '/css/ie.css', array(), '' );

I created a blank one and had to import a ton of stuff from app.css and then a lot of the custom styling from style.css I had done for normal browsers.

Hopefully this helps you out man.

Archie22is commented 10 years ago

I feel asleep while trying to answer... @gpspake answered your question. Good morning :-D

gpspake commented 10 years ago

@uphamg That's actually where it caught my eye; I created a new foundation project so I could use Reverie with Grunt and the latest version of foundation and I noticed that the file wasn't there. I'm thinking about removing that from clean.php.

uphamg commented 10 years ago

Ha I think we have the opposite problems. I specifically wanted the file. My site went from looking like a white page with a ton of stacked links and copy without the ie.css in IE8 to looking like a normal site when I added my own.

I hate styling for IE7/8 as much as anyone else bit the reality is that a lot of people still use it unfortunately.

Sent from my iPhone

On Apr 9, 2014, at 11:40 PM, George Spake notifications@github.com wrote:

@uphamg That's actually where it caught my eye; I created a new foundation project so I could use Reverie with Grunt and the latest version of foundation and I noticed that the file wasn't there. I'm thinking about removing that from clean.php.

— Reply to this email directly or view it on GitHub.

gpspake commented 10 years ago

Wait. So did adding the IE8.css file fix your problem? I'm interested because 5 breaks completely in <IE9

uphamg commented 10 years ago

It fixed IE8. I have only seen ie9 on virtual box but it seemed to be ok. Not positive on it though bit adding an ie.css (not ie8.css) fixed it in ie8.

Sent from my iPhone

On Apr 10, 2014, at 12:51 AM, George Spake notifications@github.com wrote:

Wait. So did adding the IE8.css file fix your problem? I'm interested because 5 breaks completely in <IE9

— Reply to this email directly or view it on GitHub.

uphamg commented 10 years ago

The site is http://shiftisgood.com if you care to take a look.

Any outside input/advice is welcome. I've been using Wordpress and rewrite for a couple of years now but I would never dare say I'm an expert at thoroughly knowing the intricacies of how it REALLY works.

Sent from my iPhone

On Apr 10, 2014, at 12:51 AM, George Spake notifications@github.com wrote:

Wait. So did adding the IE8.css file fix your problem? I'm interested because 5 breaks completely in <IE9

— Reply to this email directly or view it on GitHub.

uphamg commented 10 years ago

Sorry I don't follow. Bout to go to sleep it's late on the east coast.

Look forward to talking to you tomorrow more on this.

Sent from my iPhone

On Apr 10, 2014, at 1:08 AM, George Spake notifications@github.com wrote:

rewrite?

On Thu, Apr 10, 2014 at 12:00 AM, uphamg notifications@github.com wrote:

The site is http://shiftisgood.com if you care to take a look.

Any outside input/advice is welcome. I've been using Wordpress and rewrite for a couple of years now but I would never dare say I'm an expert at thoroughly knowing the intricacies of how it REALLY works.

Sent from my iPhone

On Apr 10, 2014, at 12:51 AM, George Spake notifications@github.com wrote:

Wait. So did adding the IE8.css file fix your problem? I'm interested because 5 breaks completely in <IE9

Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHubhttps://github.com/milohuang/reverie/issues/284#issuecomment-40043210 .

— Reply to this email directly or view it on GitHub.

gpspake commented 10 years ago

Heh. That was an accident. I thought I was responding to a different email. The site Looks nice. It's kind of ugly in IE8 but that doesn't matter as long as it works.

uphamg commented 10 years ago

Would you mind sending me a screen grab of what it looks like in IE8 please? It looks fine on my version of it ... the saga continues.

Thanks,

Gary

On Thu, Apr 10, 2014 at 1:17 AM, George Spake notifications@github.comwrote:

Heh. That was an accident. I thought I was responding to a different email. The site Looks nice. It's kind of ugly in IE8 but that doesn't matter as long as it works.

Reply to this email directly or view it on GitHubhttps://github.com/milohuang/reverie/issues/284#issuecomment-40043898 .

Gary Upham 7 Bent Twig Dr Greenville, SC 29605 phone. 864.561.8502

gpspake commented 10 years ago

Scratch that. It looks good in IE8. I don't know what was going on on my other machine.