milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
916 stars 196 forks source link

IE specific code question from header.php #32

Closed BodhiMcGee closed 11 years ago

BodhiMcGee commented 12 years ago

Hi, love reverie and look forward to sharing the current project.

I have a question regarding a line of code in the header.php file that targets IE 9 and above. Can you explain why your using this code?

  1. I cant figure out why you would want to apply the no-js class to IE9?
  2. Why is the only provided to IE9 plus? Shouldnt this be provided to all browsers? I notice that w3cs validator for html5 brings up an error when lang="en" is not declared in the .

Many thanks for your assistance and great work.

Bodhi McGee RSPCA Queensland Education

BodhiMcGee commented 12 years ago

I'd like to rephrase my question. Why would the no-js and the only be applied to <!--[if gt IE 8]> - shouldnt all browsers get this treatment?

Thanks very much to anyone who knows the motivation behind this.

All the best,

Bodhi

Firestorm-Graphics commented 12 years ago

firstly if declaring <!-[if gt IE 9]> its applied to all versions UPTO IE9 ,

I.E handles this a little different to other browsers,

its a hack as IE is the black sheep of the family, and unfortunately some people are still using ie 6/7/8 and while 9 is much better than its predecesors its still not quite there yet, and judging by I.E 10 in windows 8 beta its gonna be a few versions yet.

NRG-R9T commented 12 years ago

I don't know if it has to do with this, but IE9 show some strange behavior with images. most of the Images are not responsive and those that are responsive, have a black-solid-line around them. it's only in IE, I tested 9 and 8.

to activate chrome frame for IE did not solve that problem.

Firestorm-Graphics commented 12 years ago

images in wordpress generaly not responsive particularly featured image, check this link here for a good discussion and advise,

http://css-tricks.com/forums/discussion/15217/responsive-thumbnails-in-wordpress/p1

also when declaring featured image in functions.php you can use 9999px for width which works ok for images not needing to be too strict on aspect ratio

NRG-R9T commented 12 years ago

my thumbnails are fine with a fixed with, as they are well positioned and smaller than min-width.

So you say, that IE does not support responsive images in posts? that's a bummer. we have 33% visitors from IE, another 33% from firefox, and both don't scale the images in posts (especially), unlike chrome. is that a default, e.g. common known Foundation/Reverie issue or did I got something wrong? the production site is: http://greenbyte.ch

if it's normal, I would tell readers to switch their browser.

Firestorm-Graphics commented 12 years ago

its not the browsers thats the main issue its wordpress itself, however are responsive images needed in i.e ? how many devices use i.e that are smaller than a netbook?

i would look more towards how many people are using what device before looking at browser, then compare.