search

milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
916 stars 196 forks source link

header.php order of CSS #6

Closed shrwnsan closed 12 years ago

shrwnsan commented 12 years ago

Hey Zhen.

Saw this in header.php file of Reverie

<link rel="stylesheet" href="<?php bloginfo('stylesheet_url'); ?>">

<!-- Included Foundation CSS Files -->
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/foundation.css">
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/app.css">

Wondering if that should be like below instead

<!-- Included Foundation CSS Files -->
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/foundation.css">
<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/app.css">

<link rel="stylesheet" href="<?php bloginfo('stylesheet_url'); ?>">

HTH TIA
milohuang commented 12 years ago

I don't think it's necessary but it's fine :)

shrwnsan commented 12 years ago

Hey Zhen. I updated this on my fork. This will take care of Reverie's style.css in terms of not having to have "!important" on the style rulees. I'll do a push so you can check it out and see if it's okay to be merged. Thanks.

milohuang commented 12 years ago

Have merge the pull, that's helpful, thanks :)