milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
916 stars 196 forks source link

missing code in ie.css ? #83

Closed NRG-R9T closed 11 years ago

NRG-R9T commented 12 years ago

ie.css is empty in version 3.0. I saw from the history, that Reverie 2.0 had code.

is that by intention?

awshout commented 12 years ago

ie.css is no longer included in Foundation

https://github.com/zurb/foundation/issues/562

Modernizr adds lt-ie9 class for IE CSS

Firestorm-Graphics commented 12 years ago

only i.e 9 + is supported, if 6 , 7 & 8 is required then foundation 2 is required rather than 3, purhaps reverie could have a foundation 2 branch for those who cant use 3

awshout commented 12 years ago

ie8 does work except for the responsive layout, but any device using ie8 shouldn't need to be responsive anyway.

Good idea to have a separate branch for Foundation 2 though

NRG-R9T commented 12 years ago

how about line 44-49 in functions.php ?

function reverie_ie_css () {
    echo '<!--[if lt IE 9]>';
    echo '<link rel="stylesheet" href="<?php echo get_template_directory_uri(); ?>/css/ie.css">';
    echo '<![endif]-->';
}
add_action( 'wp_head', 'reverie_ie_css' );

Is this still of use?

awshout commented 12 years ago

Nope

Firestorm-Graphics commented 12 years ago

unless you plan to use any ie specific styling then no, you can remove without detrimental effect.