milohuang / reverie

Reverie is a versatile HTML5 responsive WordPress framework based on ZURB's Foundation.
http://theakiba.com/reverie/
MIT License
916 stars 196 forks source link

CSS for Embed Objects #99

Closed NRG-R9T closed 11 years ago

NRG-R9T commented 12 years ago

Some embedded Javascripts put out pictures with wrong dimensions

You can see the problem and the solution hint by a video of our partners: http://www.zedo.com/demos/testing/adwebster/GreenByte.swf

Line 223 of foundation.css needs to be adopted for this Javascript. Means the following line:

img, object, embed { max-width: 100%; height: auto; }

must be

img, object, embed { max-width: 100% }

is this somehow of an issue für Reverie (causing problems with img, object embed) or is itjust an individual problem? Will hande that with Style.css then.

NRG-R9T commented 12 years ago

"auto" is default setting for height, why it is there anyway?

I've changed it in a short therm solution for now from style.css to:


img, object, embed { max-width: 100%; height: inherit; }
rrific commented 12 years ago

It's not only an issue on Reverie. I had the exact same with Knacss from Raphael Goetter.